Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix make:cast --inbound so it's a boolean option, not value #44505

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[9.x] Fix make:cast --inbound so it's a boolean option, not value #44505

merged 1 commit into from
Oct 7, 2022

Conversation

legecha
Copy link
Contributor

@legecha legecha commented Oct 7, 2022

The php artisan make:cast --inbound option is currently ineffective unless you pass a value (--inbound=INBOUND) because it uses InputOption::VALUE_OPTIONAL.

I've changed this to VALUE_NONE, as --force and similar work, to reflect what is expected.

@taylorotwell taylorotwell merged commit f529020 into laravel:9.x Oct 7, 2022
@GrahamCampbell GrahamCampbell changed the title Fix make:cast --inbound so it's a boolean option, not value [9.x] Fix make:cast --inbound so it's a boolean option, not value Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legecha @taylorotwell